DhanushNehru / board

A black board to just write contents and display
https://board-dhanushnehru.netlify.app/
MIT License
9 stars 33 forks source link

Feature/google signin #57

Closed JeevaRamanathan closed 11 months ago

JeevaRamanathan commented 11 months ago

Fix for #49 While merging please do create a project in https://console.cloud.google.com/ and under Apis and Services i. create a OAuth 2.0 client id for web application and replace the client id in index.html (line 59). ii) Also add the Authorized JavaScript origins in OAuth 2.0 of the web app end point. If anything goes wrong kindly let me know!

netlify[bot] commented 11 months ago

Deploy Preview for board-dhanushnehru ready!

Name Link
Latest commit c1add187b214f4d650272c57a51dbbba8e1a1eab
Latest deploy log https://app.netlify.com/sites/board-dhanushnehru/deploys/65393762c5be570008974ef8
Deploy Preview https://deploy-preview-57--board-dhanushnehru.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ghost commented 11 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/DhanushNehru/board/57/0c86f3d5/c1add187b214f4d650272c57a51dbbba8e1a1eab.svg)](https://app.codesee.io/r/reviews?pr=57&src=https%3A%2F%2Fgithub.com%2FDhanushNehru%2Fboard) #### Legend CodeSee Map legend
DhanushNehru commented 11 months ago

Hi @JeevaRamanathan the client id etc, can that be as environment variables. And also the steps to be followed can you add images as well

JeevaRamanathan commented 11 months ago

Hi @DhanushNehru ,

  1. As html is a markup language it does not handle env variables, so now I have approached that in a different way using config,json file, so the client_id can be directly updated in config file.

2.Steps to be followed to enable and get the data-client_id

image

Please follow the above steps and if you are facing any issues please let me know

DhanushNehru commented 11 months ago

Thanks for your contribution @JeevaRamanathan , if you can update the readme.md / contribution.md guidelines

Or create an issue to update those, it would be very helpful for new users

JeevaRamanathan commented 11 months ago

Hi @DhanushNehru, Sure! I have raised a PR updating readme.md. #61