search

DhanushNehru / calculator

An online calculator
https://calculator-dhanushnehru.netlify.app/
MIT License
24 stars 75 forks source link

UI Enhancement - Alert when clicking on Solve Equation button without giving any equation - Changing the alert a Toast Message #154

Closed MohammedJunaid02 closed 1 month ago

MohammedJunaid02 commented 1 month ago

Hi @DhanushNehru , When we click on Solve Equation button which entering any equation then we get this error.

image

So i want to change it to a Toast Message. I will keep the UI which i have resolved for Delete History only. Please assign this to me.

Thank You

MohammedJunaid02 commented 1 month ago

@DhanushNehru , assign this Hacktober Fest label, feature enhancement labels

MohammedJunaid02 commented 1 month ago

Hey @DhanushNehru ,

I have raised the PR for this issue, Please review it once and merge it.

PR Link : https://github.com/DhanushNehru/calculator/pull/160

FYI, I have done some unit testing as well

Thank You

MohammedJunaid02 commented 1 month ago

Also @DhanushNehru , This will be the final look for the Toast Message, Please have a look

https://github.com/user-attachments/assets/aab33184-9d38-44c9-95af-dd85e2f1bca2

DhanushNehru commented 1 month ago

Looks great @MohammedJunaid02