Unity 2019 Support

[rfadeev]

Summary

Unity 2018.3 introduced new prefab workflows API resulting in obsolete method usage warnings for the project. Also selecting prefab generated by Spriter2UnityDX in project view shows infinite microloading.

IMPORTANT: New prefab workflow API requires Unity 2018.3. Currently changes are not guarded by defines to support older versions of Unity, so minimum required version for the project becomes Unity 2018.3.

Fixed all the project warnings produced by Unity 2019.1.9f1:

• Assets\Spriter2UnityDX\Editor\PrefabBuilder.cs(42,65): warning CS0618: 'ReplacePrefabOptions' is obsolete: 'This has turned into the more explicit APIs, SavePrefabAsset, SaveAsPrefabAsset, SaveAsPrefabAssetAndConnect'
• Assets\Spriter2UnityDX\Editor\PrefabBuilder.cs(42,15): warning CS0618: 'PrefabUtility.CreatePrefab(string, GameObject, ReplacePrefabOptions)' is obsolete: 'Use SaveAsPrefabAsset or SaveAsPrefabAssetAndConnect instead.'
• Assets\Spriter2UnityDX\Editor\PrefabBuilder.cs(159,51): warning CS0618: 'ReplacePrefabOptions' is obsolete: 'This has turned into the more explicit APIs, SavePrefabAsset, SaveAsPrefabAsset, SaveAsPrefabAssetAndConnect'
• Assets\Spriter2UnityDX\Editor\PrefabBuilder.cs(159,4): warning CS0618: 'PrefabUtility.ReplacePrefab(GameObject, Object, ReplacePrefabOptions)' is obsolete: 'Use SaveAsPrefabAsset or SaveAsPrefabAssetAndConnect with a path instead.'
• Assets\Spriter2UnityDX\Editor\PrefabBuilder.cs(172,6): warning CS0618: 'TextureImporterSettings.ApplyTextureType(TextureImporterType, bool)' is obsolete: 'ApplyTextureType(TextureImporterType, bool) is deprecated, use ApplyTextureType(TextureImporterType)'
• There are menu items registered under Edit/Project Settings: Spriter2UnityDX Consider using [SettingsProvider] attribute to register in the Unified Settings Window.

Changes in project settings are not comitted but can be if needed.

How to test

Tested importing scml file using Unity 2018.3.1f1 and Unity 2019.1.9f1. Open the project using Unity 2018.3 or later. Observe not compilation warnings. Import scml file and observe prefab is correctly generated. Open project settings: Edit -> Project Settings... and observe animation import option present in Spriter2UnityDX section and properly changed in scriptable object on modifications.

Closes #20

[Dharengo]

If you say it works, I'll take your word for it.

[rfadeev]

Great, thanks! In case somebody reports something gots broken, feel free to revert the changes. I tested using GreyGuy example scml from Spriter which may not cover some cases.

On a side note, I'm thinking of adding support for this project to be addable as a package as described here. This way users can modify project manifest (manifest.json) to add the package instead of installing it via .unitypackage. Do you think this would be useful?

[Dharengo]

I have not used Unity in a long time, so I have no idea what's hip right now.

If you think it's useful, you could serve both the .unitypackage and what you're suggesting so users can download whichever version they want.