search

Dhaulagiri / ember-cli-twitter-typeahead

An ember cli typeahead component based on Twitter's jquery typeahead
MIT License
28 stars 14 forks source link

Update addon to work with ember-cli 0.2.7 #9

Closed irnc closed 9 years ago

irnc commented 9 years ago

I need to use typeahead with remote dataset, for this there needs to be an ability to extent base component which now works only with local dataset.

This is the first step in which code was adjusted to run with latest ember-cli and expose component to consuming application, so it can be extended.

Later pull request would change component internals to allow extensions.

irnc commented 9 years ago

Build failed for ember-beta. Could we fix it in separate pull request to keep changes in this as small as possible?

ember-release passes all tests.

Robdel12 commented 9 years ago

I updated the deps and the tests passed for me so I merged. Here's a question for you @irnc: would you like to take this repo over and become the maintainer?

irnc commented 9 years ago

Thanks! I just noticed that my changes reseted version in package.json to 0.0.0 - I will fix it tomorrow.

I will work with this component for the future weeks, and plan to integrate Bloodhound and ember-data more tightly, if needed and possible, and describe recipes on using typeahead.js with Ember. Following this plan I can be a contributor, and if all goes well I will be happy to also maintain that component later.