Fix set button colors on the dialog

Dhaval2404 / ColorPicker

🎨 Color Picker Library for Android

Apache License 2.0

277 stars 39 forks source link

Closed SubhrajyotiSen closed 1 year ago

SubhrajyotiSen commented 4 years ago

Setting color after showing the dailog does not seem to work on multiple devices

Devices tested on: Xiaomi Redmi Note 5 Pro running Android 11 Samsung Galaxy S20 Running Android 10

SubhrajyotiSen commented 4 years ago

Rest of the formatting changes are due to running ktlint included in the project

SubhrajyotiSen commented 4 years ago

Please release a new version of the library if possible once this is merged. Another project is dependent on this fix.

Dhaval2404 commented 4 years ago

@SubhrajyotiSen Everythings looks good. I will try to release the new version over the weekend.

Thank you so much for your contribution!

SubhrajyotiSen commented 4 years ago

Hi, can this be merged?

Dhaval2404 commented 4 years ago

@SubhrajyotiSen Ohh So Sorry! I almost forgot this. Thanks for the reminder. I will do it by EOD.

Thank you.

Dhaval2404 commented 4 years ago

@SubhrajyotiSen It seems like setting a color before showing a dialog not working in a stock ROM 😢.

I have verified the same in the following devices:

Can you please verify the same if possible?

Tomorrow, I will check on Redmi Note 5 Pro to find any alternate solution.

SubhrajyotiSen commented 4 years ago

I will take a look at this tomorrow and try getting a solution that works universally

SubhrajyotiSen commented 4 years ago

Hey. I tried my changes on a Pixel XL (Android 10) Emulator. The color seems to work