Dhaval2404 / ColorPicker

🎨 Color Picker Library for Android
Apache License 2.0
277 stars 39 forks source link

The Positive and Negative buttons are not seen when using dark theme on Android 11 #16

Open Istalexnik opened 3 years ago

Istalexnik commented 3 years ago

Summary

Code to reproduce

Android version

Impacted devices

Installation method

SDK version

Other information

Istalexnik commented 3 years ago

The issue is only on 1.2 and 2.0 1.1 does not have that problem

Dhaval2404 commented 3 years ago

@Istalexnik Sorry for the late reply.

It seems to be working fine for me. Can you please provide me a screenshot, This might help me understand the issue. Screenshot_1613311484

Thank you!

Aashir1111 commented 3 years ago

i m also facing this issue, unable change the color of positive and negative button Screenshot_20210222-180752_IRTI 1

Dhaval2404 commented 3 years ago

@Aashir1111 Did you try adding color resource in color.xml?


<resources>
    <!-- Here you can add color of your choice  -->
    <color name="positiveButtonTextColor">@color/colorAccent</color>
    <color name="negativeButtonTextColor">@color/colorAccent</color>
    <color name="bottomSheetDividerColor">#F5F5F5</color>
</resources>
SimpleappRed commented 3 years ago

The same problem Android 11 color.xml added

yourdaum commented 3 years ago

@SimpleappRed I got same problem and found need to put colors.xml in "values-night-v8" folder to override.

ParthParekh-dev commented 3 years ago

Facing same issue on android 10. In light mode the ok and cancel button are barely visible. Added color tag in colors.xml as well. Didnt solve

AnandhuKaleshAk commented 3 years ago

@ParthParekh-dev I got the same problem here,I think the OK and and cancel button is barely visible only when your app doesn't support dark theme,My application doesn't support Dark theme,But when i changed the theme of application to Day Night it is working perfectly

dismilz commented 1 year ago

@SimpleappRed I got same problem and found need to put colors.xml in "values-night-v8" folder to override.

Worked nicely