Closed kwartler closed 6 years ago
Hi @kwartler! This is a nice suggestion. Thank you for the suggestion as well as for interest in contributing. Now that the package has been officially released on CRAN, I do not feel the same pressure to get the basic functionality to work. I can start focussing on making the functions more robust. I also notice from your code that you were able to use httr
to pass headers which for some reason I struggled after encapsulating the logic in auth()
.
Anyways, I will appreciate if you can actively contribute towards it and send me a pull request. Also if possible, please spread the word. Hopefully there are many folks who may find it easier to use this than to start from scratch.
I have looked at this and believe, the difference lies in using jsonlite
. The content
of the response
is returned as a json
and converting it to a data frame using fromJSON()
addresses the issue by default and gives it a normalized form. At this time, no implementation changes will be done. When the enhancement to replace RCurl
is undertaken, this issue can be revisited.
When I perform a GET /fills I get an uneven nested list. Your code grabs specific list elements to overcome this. What about something like below which is what I used before seeing your package (I have my own private). This way you get the complete response. Just my $0.02 though. If you need a contributor I would be happy to spend some time on your package if you need it. :)
The interesting bit is arranging the info into a df filled w/ NULL if needed and then using grepl to perform a subset based on product. Again, just my $0.02 and trying to help!