search

DheerajAgarwal / rgdax

Wrapper for Coinbase pro (erstwhile GDAX) Cryptocurrency exchange
Other
34 stars 16 forks source link

Is this package still working with current API? #11

Closed siulynot closed 3 years ago

siulynot commented 4 years ago

Hello, i try to submit a request but i only get an empty error message, is this package still working or is it deprecated?

siulynot commented 4 years ago

When i try to submit a command i get:

accounts("api-key", "api-secret", "passphrase")

error:
heiko1234 commented 4 years ago

I also wonder about this package.

I used it in former times and it worked fine. Now I get an Error

Fehler in function (type, msg, asError = TRUE) : error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

which looks to me like an error with the RCurl package and the GET function.

I try to make a rework about this function, but so far I am not successful.

DheerajAgarwal commented 3 years ago

@heiko1234 and @siulynot Apologies for taking a long time to come back to this. Last year was unprecendented in so many ways. Is this still an issue? Happy to take a look if you have a reproducbile example.

jcalebsmith commented 3 years ago

This is still an issue in cran version 1.0 test <- accounts( api.key = "[key], secret ="[secret]", passphrase = "[passphrase]") results in the following error:

Error in function (type, msg, asError = TRUE) : error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

MADscientist314 commented 3 years ago

This is still an issue in cran version 1.0 test <- accounts( api.key = "[key], secret ="[secret]", passphrase = "[passphrase]") results in the following error:

Error in function (type, msg, asError = TRUE) : error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

I am still having the same issure, but Ive read a lot from other on stack exchange that this issue is related to RCurl still using tsl1 security, or has something to do with utilizing and old version of openssl in git bash. Either way, I'm trying to troubleshoot my way thrrough it now and will report back if I have any success. I honestly might end up dockerizing an rstudio-server or Rjupyternotebook from jupyter stacks. If so I'll push a link to the pre-built image that I will host on docker hub (I am honestly suprised that I wasnt able to find an rgdax container already).

jcalebsmith commented 3 years ago

It may just be a matter of migrating from the "RCurl" package to something more recent like "curl" and updating the affected function(s) accordingly. I'll play around with a local copy as well and report back if I have any luck.

DheerajAgarwal commented 3 years ago

Thanks mate, appreciate the help. I will surely find some time today and look at these too.

On Sat, 6 Feb 2021 at 1:46 am, Caleb Smith notifications@github.com wrote:

It may just be a matter of migrating from the "RCurl" package to something more recent like "curl" and updating the affected function(s) accordingly. I'll play around with a local copy as well and report back if I have any luck.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/DheerajAgarwal/rgdax/issues/11#issuecomment-774076168, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDD4AOQIQL7FJJ2GVO6XRDS5QAFHANCNFSM4N4S5WKQ .

-- Dheeraj Agarwal Sent from my iPhone

DheerajAgarwal commented 3 years ago

Looking at everything, the best appoach in my mind to spend some time and give the package a makeover by using httr. It has been a long pending aspiration to move away from RCurl so may be now is the time. Will need extensive testing and changing almost all functions to read the new auth. Any other ideas are welcome.

MADscientist314 commented 3 years ago

@DheerajAgarwal any update on this issue? I am happy to contribute to the httr makeover testing if you have something you are working on.

MADscientist314 commented 3 years ago

Here is a less than optimal but temporary fix for anyone looking for a work around.

  1. Install docker. (Install desktop first if you are on windows or mac)
  2. Pull the docker bioconductor rstudio-server docker container
  3. Install the rgdax package
  4. Run your code from the docker container based rstudio server

For some reason the version of RCurl running on the docker container allows for the tsl1 security. Told ya it wasn't optimal.

DheerajAgarwal commented 3 years ago

Despite my best intentions, I haven’t been able to find any time to look into this mate.

I tried a minor change a week or so ago but it didn’t work as expected. The latest dev should be good for use. At this stage, I will gladly take code contributions.

From: Michael Jochum notifications@github.com Sent: Thursday, 4 March 2021 1:48 AM To: DheerajAgarwal/rgdax rgdax@noreply.github.com Cc: Dheeraj Agarwal dheeeraj.agarwal@gmail.com; Mention mention@noreply.github.com Subject: Re: [DheerajAgarwal/rgdax] Is this package still working with current API? (#11)

@DheerajAgarwal https://github.com/DheerajAgarwal any update on this issue? I am happy to contribute to the httr makeover testing if you have something you are working on.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DheerajAgarwal/rgdax/issues/11#issuecomment-789766614 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDD4AMDNLML6PAP7NF3PO3TBZD2TANCNFSM4N4S5WKQ . https://github.com/notifications/beacon/ADDD4AIQ7WY6B7ZUEA6OCFLTBZD2TA5CNFSM4N4S5WK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOF4JODVQ.gif

rogergarciamarfany commented 3 years ago

Hi Dheeraj, Any other news? I'm trying to run the rgdax from a Windows and still get the message:

Error in function (type, msg, asError = TRUE) : error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

I'm doing a university project and It'd be very useful to access rgdax package and use it.

I've installed the packages from your repository and still get the same error message ...

Hope you can help whenever you can!

DheerajAgarwal commented 3 years ago

Hello @rogergarciamarfany. I was finally able to make a fix. GET is working fine but before I release it to CRAN, i need to test the following.

  1. POST and DELETE.
  2. Auth based functions other than account, accounts, holds & account_hist.
  3. Complete testing pm macOS.

The response structure is changed and I need additional transformations which I am working on now for the rest of the functions. Note, that the functions work and will get the right content, but will not transform it correctly and hence could end up in the wrong flow leading to error or garbage data.

I will push my working code to dev branch tonight, however please be aware of the untested functions. If you or anyone can help test and would like to contribute, it will be highly appreciated.

jeremiahsb commented 3 years ago

I can confirm that on the latest dev branch it is not working for placing orders. I get "invalid signature" messages returned from the API. I am able to successfully pull orders and query accounts.

DheerajAgarwal commented 3 years ago

Agreed. Fixed POST last night and working through the day to test it on sandbox. Expect another dev push tonight AEDT.

DheerajAgarwal commented 3 years ago

Updates made to all auth-based functions and changes pushed to dev. @jeremiahsb Would you be so kind and help me test if you can reproduce your issue?

jeremiahsb commented 3 years ago

Looks like there's an issue with the package list. I get this error on the newest version:

Skipping 1 packages not available: httr plyr Installing 2 packages: httr plyr, RCurl Installing packages into ‘C:/R’ (as ‘lib’ is unspecified) Error: Failed to install 'rgdax' from GitHub: (converted from warning) package ‘httr plyr’ is not available for this version of R

A version of this package for your version of R might be available elsewhere, see the ideas at https://cran.r-project.org/doc/manuals/r-patched/R-admin.html#Installing-packages

DheerajAgarwal commented 3 years ago

I was able to install the package from github using install_github("DheerajAgarwal/rgdax", ref="dev"). I had to unload and remove the existing installation of rgdax.

The other issue I can think of is the R version itself. RCurl, plyr have a new version supporting R4.0.4 and if you have an older version, it could be an issue. Although, I feel this should not be an issue.

jeremiahsb commented 3 years ago

Weird, manually removing the package and then loading again did resolve the issue for me. I can confirm the add_order functionality is working. I'll test out the delete_order functionality tomorrow. One thing I noticed is that for public_orderbook, setting level to 2 or 3 yields only level 1 results. Do you want me to open different issues for each of these or keep posting in this issue?

DheerajAgarwal commented 3 years ago

Thanks @jeremiahsb . I have noticed the level 2 and 3 odd behavior too for public_orderbook. I have tried a few things since morning and none seem to be working. May be I am mising something in the docs that needs to change my request.

It will help if you want to open separate issues. Makes it easier to track and prioritise.

DheerajAgarwal commented 3 years ago

Closing this one as the original issue has been resolved.