DheerajAgarwal / rgdax

Wrapper for Coinbase pro (erstwhile GDAX) Cryptocurrency exchange
Other
33 stars 16 forks source link

index in pubic candles is not in the right order #12

Closed MotivaoCrypto closed 3 years ago

MotivaoCrypto commented 3 years ago

Index in pubic_candles does not retrieve the data from Coinbase in the right order .

DheerajAgarwal commented 3 years ago

Could you give me some more details? if you have a screenshot and which sample entries are out of order that will be help.

On Fri, 1 Jan 2021 at 1:37 pm, bonetjoshua notifications@github.com wrote:

Index in pubic_candles does not retrieve the data from Coinbase in the right order .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DheerajAgarwal/rgdax/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDD4AIAN3VOSJACCH77PDDSXUYN7ANCNFSM4VP5LSJQ .

-- Dheeraj Agarwal Sent from my iPhone

MotivaoCrypto commented 3 years ago

The issue is the index on the left column is in decreasing order even though the times are in order

On Thu, Dec 31, 2020 at 7:31 PM Dheeraj Agarwal notifications@github.com wrote:

Could you give me some more details? if you have a screenshot and which sample entries are out of order that will be help.

On Fri, 1 Jan 2021 at 1:37 pm, bonetjoshua notifications@github.com wrote:

Index in pubic_candles does not retrieve the data from Coinbase in the right order .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DheerajAgarwal/rgdax/issues/12, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADDD4AIAN3VOSJACCH77PDDSXUYN7ANCNFSM4VP5LSJQ

.

-- Dheeraj Agarwal Sent from my iPhone

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DheerajAgarwal/rgdax/issues/12#issuecomment-753247988, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMIUOYFDJPA624UHQTWBVOLSXU6Z3ANCNFSM4VP5LSJQ .

-- Sincerely,

Joshua Bonet M.Sc. Applied Mathematics B.Sc. Pure Mathematics Cel: (702) -721 -3591 Motivao Math Tutoring: www.motivao.com

DheerajAgarwal commented 3 years ago

I have looked at this and realized that the data is returned from the API in that format. Thinking about it, it actually makes sense because the candles are listed in chronological order. So the entry at 12:00 am is the oldest entry for the day.