search

DheerajAgarwal / rgdax

Wrapper for Coinbase pro (erstwhile GDAX) Cryptocurrency exchange
Other
33 stars 16 forks source link

Quick makeover to restore package functionality. #14

Closed MarcoZanon closed 3 years ago

MarcoZanon commented 3 years ago

Thank you for creating and sharing this bot. I applied some crude fixes to address the error message:

error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

They will require for sure some optimization, but they are good enough to execute GET, POST and DELETE commands properly via httr .

I could not test them with macOS, so anything related to mac OS is still unchanged.

They may be too messy for a pull request, but I wanted to submit them to your consideration.

DheerajAgarwal commented 3 years ago

Thanks. I will test it on macos and try to push this to Cran.

On Mon, 15 Feb 2021 at 8:43 am, Marco Zanon notifications@github.com wrote:

Thank you for creating and sharing this bot. I applied some crude fixes to address the error message:

error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

They will require for sure some optimization, but they are good enough to execute GET, POST and DELETE commands properly via httr .

I could not test them with macOS, so anything related to mac OS is still unchanged.

You can view, comment on, or merge this pull request online at:

https://github.com/DheerajAgarwal/rgdax/pull/14 Commit Summary

  • Quick makeover to restore package functionality.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DheerajAgarwal/rgdax/pull/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDD4APAMEGK3DPMW4REZGTS7A7XFANCNFSM4XTUFQPQ .

-- Dheeraj Agarwal Sent from my iPhone

svdijkman commented 3 years ago

I tested this patch, but got a message that just said "BadRequest" as a return of the account() function. Not sure if it's my fault, as I have not yet used this package before, so could've made a mistake.

MarcoZanon commented 3 years ago

I tested this patch, but got a message that just said "BadRequest" as a return of the account() function. Not sure if it's my fault, as I have not yet used this package before, so could've made a mistake.

The account() function likely still needs fixing. To be fair, I did not test it. I modified only the accounts() function. I confirm that the fix still works for me.

DheerajAgarwal commented 3 years ago

I have fixed issues with the auth functions and any dependent functions on auth should work fine on windows. macos is still under fixes. Thanks for your contribution.

MarcoZanon commented 3 years ago

Excellent! Keep up the good work!