The public_orderbook function does not appear to be passing the level to the CBP API

DheerajAgarwal / rgdax

Wrapper for Coinbase pro (erstwhile GDAX) Cryptocurrency exchange

Other

33 stars 16 forks source link

The public_orderbook function does not appear to be passing the level to the CBP API #15

Closed jeremiahsb closed 2 years ago

jeremiahsb commented 3 years ago

In version 1.1.0, using the public_orderbook for BTC-USD and level = 1, yields a tibble with 1 row, 7 columns. This is to be expected. Using level 2 yields the same output. I believe the issue is in the parse_response function. It doesn't seem to be passing the query parameter to the API. manually running httr::GET("https://api.pro.coinbase.com/products/BTC-USD/book?level=2") then passing the response into content() yields the expected 50 row by 7 columns.

DheerajAgarwal commented 2 years ago

Hi. This is now fixed and I am testing the code for CRAN push. The issue was that the query parameter was getting set as NULL. I have pushed teh changes to dev, so should be good to go for meanwhile.