search

DheerajKhajuria / pimatic-mysensors

mysensors
http://forum.mysensors.org/topic/797/pimatic-mysensors-controller-plugin
GNU General Public License v2.0
23 stars 24 forks source link

simplify config schema for DTH and minor improvements in display #1

Closed fritz-hh closed 9 years ago

fritz-hh commented 9 years ago
fritz-hh commented 9 years ago

By the way, thank you for this great plugin!

fritz-hh commented 9 years ago

Hi,

I plan also (if I find time to do it) to propose a pull request so that DHT also reads at displays battery status. Would be nice if you could tell me if you are interessted in it ahead of time, to avoid any useless work.

Is there any reason why you did deactivate bug reporting. I think it would be very usefull, as I am sure that the pimatic/mysensors community could contribute to improve the plugin even more.

Regards

fritz

DheerajKhajuria commented 9 years ago

Hi Fritz,

just saw your mail. Thanks for showing your interest in the plugin . sure, i would like the community to contribute to the plugin development.

I had enabled the issues tab in github :)

regards, Dheeraj

On Fri, Feb 27, 2015 at 1:41 AM, fritz-hh notifications@github.com wrote:

Hi,

I plan also (if I find time to do it) to propose a pull request so that DHT also reads at displays battery status. Would be nice if you could tell me if you are interessted in it ahead of time, to avoid any useless work.

Is there any reason why you did deactivate bug reporting. I think it would be very usefull, as I am sure that the pimatic/mysensors community could contribute to improve the plugin even more.

Regards

fritz

— Reply to this email directly or view it on GitHub https://github.com/DheerajKhajuria/pimatic-mysensors/pull/1#issuecomment-76260272 .

DheerajKhajuria commented 9 years ago

Please see my review comments

fritz-hh commented 9 years ago

Hi, As long as the data provided have different units (like in your example) this is not an issue, as it is possible to distinguish the values using the units. Indeed it would not be possible to have more than one DTHxx sensor connected to the same node. Do you see a use case for having more than 1 DTH connected to the same node? Regards

fritz-hh commented 9 years ago

I understand your argumentation for keeping the sensor ids. I will close this pull request and open another one covering the following topics only: