search

DheerajKhajuria / pimatic-mysensors

mysensors
http://forum.mysensors.org/topic/797/pimatic-mysensors-controller-plugin
GNU General Public License v2.0
23 stars 24 forks source link

Remove toasts on ui #51

Closed Heizelmann closed 8 years ago

Heizelmann commented 8 years ago

The overlaying messages shown on each sensor value send is disturbing other outputs and unnecessary, logging is enough.

ako82 commented 8 years ago

Word! Is there a way to disable them we don't know about?

PascalLaurens commented 8 years ago

I think replacing every env.logger.info with env.logger.debug would resolve your problem.

Heizelmann commented 8 years ago

Thanks, this would help. I vote for to change this in code.

ako82 commented 8 years ago

I bet you say this is a stupid question, but could you guys prevent me from searching and tell me in which file the change needs to be done. Thanks in advance for that!

PascalLaurens commented 8 years ago

You can do a search and replace in MySensors.coffee.

To be honest, I'm also not a big fan of the info messages, but I don't know if @DheerajKhajuria wants to change this.

Heizelmann commented 8 years ago

The popups appear always whatever page you have opened. With a lot of sensor traffic this is really disturbing. Other sensor plugins like homeduino don't do that toasts. A common behavior in pimatic is another argument for removing it.

sweebee commented 8 years ago

I think you still need it for switches and dimmers because of the 2-way communication of mysensors. Then you know the message arrived correctly. Or there must be a way to let the switch switch only when the message arrived.

Heizelmann commented 8 years ago

@sweebee: You are right, very important comment. I have only seen it from the input side - means sensors - and there it is still a problem. On actuator side it is a good idea to enhance switch devices by a pending state, or (not so good) let them switch back to the old state after two or three seconds. May be it is easier to distinguish between sensor and actuators and showing the toast only for actuators.

DheerajKhajuria commented 8 years ago

Guys, would love to receive the pull request on this issue. I myself some time feels toast msgs are bit annoying sometime.

Icesory commented 8 years ago

https://github.com/Icesory/pimatic-mysensors/commit/2ccf4cfc1e14bd26040652001da43a405ca8c196