DheerajKhajuria / pimatic-mysensors

mysensors
http://forum.mysensors.org/topic/797/pimatic-mysensors-controller-plugin
GNU General Public License v2.0
23 stars 24 forks source link

MySensorsMulti only emits a value if it is different from the previous one #76

Closed Heizelmann closed 8 years ago

Heizelmann commented 8 years ago

MySensorsMulti only emits a value if it is different from the previous one. So it behaves different as other normal sensor classes. I guess this is a bug and should be corrected.

Heizelmann commented 8 years ago

From discussion on https://forum.pimatic.org/topic/1690/problem-with-mysensorsmulti/29

sebastianha commented 8 years ago

I also had a similar finding: #39

sweebee commented 8 years ago

The device doesnt check If the value has changed. (Atleast I cant find it). https://github.com/DheerajKhajuria/pimatic-mysensors/blob/development/MySensors.coffee#L1907

Must me the default behavior of pimatic.

sweebee commented 8 years ago

Or Yes, have to move the emit there, than it should save All data.

Ah, this line https://github.com/DheerajKhajuria/pimatic-mysensors/blob/development/MySensors.coffee#L1960

sweebee commented 8 years ago

Could you test those changes?

Heizelmann commented 8 years ago

Looks good. I am happy with this!