search

DheerajKhajuria / pimatic-mysensors

mysensors
http://forum.mysensors.org/topic/797/pimatic-mysensors-controller-plugin
GNU General Public License v2.0
23 stars 24 forks source link

[pimatic 0.9] Destroy method implementations incomplete #79

Closed mwittig closed 8 years ago

mwittig commented 8 years ago

The destroy method implementations are incomplete. It is required to deregister event callback handlers, for "rfValue" in particular!

mwittig commented 8 years ago

@sweebee Are you in the position to look into this or do you want me to do it?

sweebee commented 8 years ago

Don't know exactly how to do it. You mean these? https://github.com/DheerajKhajuria/pimatic-mysensors/blob/development/MySensors.coffee#L678

mwittig commented 8 years ago

Yes, exactly. I have done the necessary changes. Please review them carefully and test them as I don't have setup for mysensors right now. Tia.

sweebee commented 8 years ago

Works good so far!