props collison issue fixed for button component

DhiWise / dhiwise-nodejs

DhiWise Node.js API generator allows you to instantly generate secure REST APIs. Just supply your database schema to DhiWise, and a fully documented CRUD APIs will be ready for consumption in a few simple clicks. The generated code is clean, scalable, and customizable.

https://dhiwise.com

Apache License 2.0

318 stars 89 forks source link

props collison issue fixed for button component #14

Closed shubhamkhunt04 closed 2 years ago

shubhamkhunt04 commented 2 years ago

Fixed the default props and default argument collision issue.

I have followed the default props pattern for all components in #PR12 and followed code consistency for all components because previously in some components accept default arguments and some accept default props and some accept both(default props and default argument) so there might be collision occurs between default props and default arguments. I have fixed this for the button component(#PR14) and in #PR12 for all components.

shubhamkhunt04 commented 2 years ago

Thanks! @ravisojitra @saloni137 @krinaSardhara for reviewing and merging.