search

DhrBaksteen / ArduinoOPL2

Arduino library for use with the OPL2 board (YM3812) and OPL3Duo (YMF262)
MIT License
198 stars 39 forks source link

More VGM support for Arduino's play.py #18

Closed vincentbernat closed 6 years ago

vincentbernat commented 6 years ago

Some VGM (like zero_wing.vgz) contains a null opcode. We skip it. opl2play.cpp seems to do the same thing. Some VGM also contain commands for other chips. Skip those commands. Again, like opl2play.cpp.

I still have many VGM not playing, but reading the spec, I see this is a quite complex format...

vincentbernat commented 6 years ago

In fact, I am able to play most VGM now. The unplayable ones were for the OPL3.

ghost commented 6 years ago

Glad to hear it. Yes, VGM format supports a number of different chips. So if I understand it correctly, the change is no longer required?

vincentbernat commented 6 years ago

It still is. For example, I need it for the shipped zero_wing.vgz. Maybe the "ignore other chips" part is not needed.

ghost commented 6 years ago

I forgot that one file can target multiple chips. Agreed that only failing when there is no YM3812 clock speed makes more sense.