DhrBaksteen / ArduinoOPL2

Arduino library for use with the OPL2 board (YM3812) and OPL3Duo (YMF262)
MIT License
198 stars 39 forks source link

SerialIface.ino: ensure bufsize transmission is using only "\n" #19

Closed vincentbernat closed 6 years ago

vincentbernat commented 6 years ago

Other commands are terminated by "\n", not "\r\n". The Python program is unaffected by this as it handles both situation. However, other programs may not and it seems better to make the protocol strict.

ghost commented 6 years ago

Trying to approve..

vincentbernat commented 6 years ago

Yes, I have a patch for ScummVM here and a patch for DOSBox here. I am still testing them, but they seem to work just fine.