Was trying to figure out why my waveforms didn't sound right, then found this.
Note that setInstrumet uses the right mask, which is why loading presets / whole instruments works fine.
Far as I can tell it's fine to have this extra 3rd bit around even on an opl2 (though it won't be respected) -- since setInstrument does that already.
I updated setDrumInstrument as well, but I've not read up on the details for drums yet so let me know if I should remove that one.
Was trying to figure out why my waveforms didn't sound right, then found this. Note that setInstrumet uses the right mask, which is why loading presets / whole instruments works fine.
Far as I can tell it's fine to have this extra 3rd bit around even on an opl2 (though it won't be respected) -- since setInstrument does that already.
I updated setDrumInstrument as well, but I've not read up on the details for drums yet so let me know if I should remove that one.