search

Dhravya / dhravyaAPI

2 stars 0 forks source link

Ratelimits. #31

Open Dhravya opened 2 years ago

Dhravya commented 2 years ago

Ratelimits are extremely important and we need to have some sort of rate limits.

PolyAnthi commented 2 years ago

This can come in the near future when we grow alot imo.

Dhravya commented 2 years ago

no, the issue is someone can just decide to send a billion requests in a second and we would have nothing to do about it

PolyAnthi commented 2 years ago

Not necessarily as 1) thats impossible, 2) we would notice, 3) why would anyone do that

On Sat, 8 Jan 2022, 13:10 Dhravya Shah, @.***> wrote:

no, the issue is someone can just decide to send a billion requests in a second and we would have nothing to do about it

— Reply to this email directly, view it on GitHub https://github.com/Dhravya/dhravyaAPI/issues/31#issuecomment-1007987025, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS7GXS22LCNGPYXNE77QJ7TUVAZV5ANCNFSM5LPIXKFQ . You are receiving this because you commented.Message ID: @.***>

Dhravya commented 2 years ago

@itsnotrin Don't you think ratelimits are important tho?

itsnotrin commented 2 years ago

We need them.

Dhravya commented 2 years ago

alright, i checked the notification pretty late

Just mention the limits here and i'll implement it

itsnotrin commented 2 years ago

I say we have per endpoint rate limits

Dhravya commented 2 years ago

yeah ofc, per endpoint limits make the most sense