search

Dhravya / dhravyaAPI

2 stars 0 forks source link

/lyrics Endpoint #33

Closed PolyAnthi closed 2 years ago

PolyAnthi commented 2 years ago

Added: /lyrics endpoint (uses SRA and LyricsOVH) SQLite Database for caching

Removed: Unwanted Import

To be removed when merged: /coin_value endpoint

itsnotrin commented 2 years ago

Believe we need to have those qr_code files for the qr code endpoint to work.

itsnotrin commented 2 years ago

Also would prefer if we could use an async sqlite3 library, would work better for us in the long term with multiple requests

itsnotrin commented 2 years ago

Line 424 on app.py , can you explain why you removed the check for missing lyrics? That'll just cause app errors, no?

itsnotrin commented 2 years ago

Denied until these things are fixed

PolyAnthi commented 2 years ago

Can we get this merged soon so when we have new code we have a fresh PR?

itsnotrin commented 2 years ago

I'll review after my dinner, won't take me long

PolyAnthi commented 2 years ago

I'll review after my dinner, won't take me long

No problem

PolyAnthi commented 2 years ago

You mean T or D?

On Sun, 9 Jan 2022, 18:02 itsnotrin, @.***> wrote:

@.**** requested changes on this pull request.

Do what I suggested on wyr please

— Reply to this email directly, view it on GitHub https://github.com/Dhravya/dhravyaAPI/pull/33#pullrequestreview-847288243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS7GXS2RE3YJMV74XXGI3QLUVHEVBANCNFSM5LQQWJDQ . You are receiving this because you authored the thread.Message ID: @.***>

itsnotrin commented 2 years ago

I mean make an endpoint for either one and then an endpoint for both so

/truth /dare /truthordare

PolyAnthi commented 2 years ago

Ah okay. So truthordare sends both, truth sends a truth and dare sends a dare

On Mon, 10 Jan 2022, 08:37 itsnotrin, @.***> wrote:

I mean make an endpoint for either one and then an endpoint for both so

/truth /dare /truthordare

— Reply to this email directly, view it on GitHub https://github.com/Dhravya/dhravyaAPI/pull/33#issuecomment-1008646519, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS7GXS7JKQARQPW6AOTPCDDUVKLGDANCNFSM5LQQWJDQ . You are receiving this because you authored the thread.Message ID: @.***>

itsnotrin commented 2 years ago

Yes

PolyAnthi commented 2 years ago

Aight can do that tonight

On Mon, 10 Jan 2022, 20:37 itsnotrin, @.***> wrote:

Yes

— Reply to this email directly, view it on GitHub https://github.com/Dhravya/dhravyaAPI/pull/33#issuecomment-1009321831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS7GXSZM4PRGVLRG64J6HTTUVM7RRANCNFSM5LQQWJDQ . You are receiving this because you authored the thread.Message ID: @.***>

Dhravya commented 2 years ago

Damn this one has been in review since a long time

itsnotrin commented 2 years ago

Happy, merging.