Dhruti90 / google-gdata1111

Automatically exported from code.google.com/p/google-gdata
0 stars 0 forks source link

No settings to comprehensively specify that all requests use SSL #325

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I suppose this is more of a feature request than a bug.  We are looking for 
a way to encrypt all HTTP requests made by the .Net client library with 
SSL.  This does not appear to be possible without modification to the 
client source.

Examples:

- Requests performed by a given Service
- Requests for a given Query (this alone appears to be supported with a 
"UseSSL" property on FeedQuery which implicitly modifies the feed base URI 
to start with "https://").  However, there are many places where Queries 
are implicitly created and used in the client without the caller having the 
opportunity to set this property.
- FeedEntry Insert() and Update() calls-- these appear to use the Post link 
from the feed verbatim, which always comes back from the server as http.
- Type-specific feed links, such as SpreadsheetEntry.Worksheets, which uses 
the worksheetsfeed link verbatim, which always comes back from the server 
as http.

Ideally all requests would flow through a central code path that would 
scrub the URL using a global setting of some sort-- similar to 
FeedQuery.UseSSL but more general in scope.

Original issue reported on code.google.com by jeremy%d...@gtempaccount.com on 30 Jan 2010 at 4:43

GoogleCodeExporter commented 9 years ago
BTW, I worked around this locally by injecting some code in GDataRequest that 
rewrites 
the scheme portion of the URL, and this appears to be working.

Original comment by jeremy%d...@gtempaccount.com on 30 Jan 2010 at 5:10

GoogleCodeExporter commented 9 years ago
You mind sharing the code with me? 

I actually consider it a bug in the services that they do not report POST links 
back as HTTPS when you did a 
query over HTTPS.....

Original comment by fman...@gmail.com on 1 Feb 2010 at 8:46

GoogleCodeExporter commented 9 years ago
Certainly.  Patch file (against revision 973) attached.

Original comment by jeremy%d...@gtempaccount.com on 1 Feb 2010 at 7:14

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed it a bit different (but not much) and checked it in. Let me know if that 
works for you.

Original comment by fman...@gmail.com on 3 Feb 2010 at 12:18

GoogleCodeExporter commented 9 years ago
BTW, we've been using this fix for some time now and it works great.  Thanks!

Original comment by j...@google.com on 8 Apr 2010 at 6:26