dharmesh-hemaram commented 3 weeks ago

Description

This pull request includes a small change to the libs/acf/main-world/src/lib/main-world-background.ts file. The change ensures that the script is executed in all frames of the tab by adding the allFrames: true property to the target object.

libs/acf/main-world/src/lib/main-world-background.ts: Added allFrames: true to the target object in the chrome.scripting.executeScript call to ensure the script runs in all frames of the tab.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code (E2E)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (DOCS)
[ ] I have made corresponding changes to the blog (BLOG)
[ ] My changes generate no new warnings (SONAR)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Create video on functionality
[ ] Any dependent changes have been merged and published in downstream modules

nx-cloud[bot] commented 3 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 34380ac2fef904712481392ab2c99a000b020c65. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

- [`nx run-many -t build -p acf-options-page acf-extension --prod --base-href https://dev.getautoclicker.com/ --verbose`](https://cloud.nx.app/runs/zMkrWVHNH1?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.