search

Dhvanit41 / facebook-bot

2 stars 0 forks source link

Review Result - Issues Found #1

Open sisengul opened 2 years ago

sisengul commented 2 years ago

Minus Point [-] Poor Readme [-] Not scalable bot controller [-] Using RDBMS but doesn't specify its schema [-] Doesn't have unit testing [-] Bad handling error :( [-] Doesn't handle incorrect date format [-] Buggy can't interact with the bot again after the birthday conversation [-] Ugly commit and not rebased :(, it its 100 commits, and some of them are duplicates

Plus Point [+] Page deployed with heroku [+] Birthday Calculation is correct [+] Demo Works fine [+] Env.example exist [+] MVC pattern

Neutral [.] Plain Js [.] No dockerization [.] No AWS [.] No React

Doesn't handle incorrect date It's a one-way flow, if the input isn't correct it will pass through. Common flow is the user will get the same question Now i can't event talk with the bot :(

ashwintiwari88 commented 2 years ago

@Dhvanit41 would you like to make improvements based on the feedback above ?

Dhvanit41 commented 2 years ago

Hi i will make changes on feedback as soon as possible

Thanks Dhvanit popat

On Tue, 12 Apr, 2022, 8:40 pm Ashwin Tiwari, @.***> wrote:

@Dhvanit41 https://github.com/Dhvanit41 would you like to make improvements based on the feedback above ?

— Reply to this email directly, view it on GitHub https://github.com/Dhvanit41/facebook-bot/issues/1#issuecomment-1096855538, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL5TMDHZSN22PIZG25N43WLVEWG6XANCNFSM5S3LVEAQ . You are receiving this because you were mentioned.Message ID: @.***>