Dhwty / flist-messenger

A multi-platform desktop client for the F-Chat protocol.
19 stars 10 forks source link

Join/Leave affecting login? #53

Closed Dhwty closed 10 years ago

Dhwty commented 11 years ago

From this bug report: http://www.f-list.net/view_bugreport.php?id=1561.

User claims unticking Join/Leave notices causes him to be unable to log in. Says once he changed the setting, he could suddenly connect again.

Can get user list and ticket, but can't connect to chatserver after selecting a character. Gets "Socket Error: The remote host closed the connection". User was able to connect with any other client he tried. I have been completely unable to reproduce this.

aliciasprig commented 10 years ago

I haven't tried replicating this bug, but going by the description I have encountered something like it before while refactoring the code for the client. The root cause I found was an unitialised variable that tracked the connection state of the client.

It was a pain to track down as changing the code to help trace the cause would cause it work again, but it would break again when I made some other change. The fix to this type of bug is to simply ensure that every variable is initialised to proper default.

I'm tempted to close this right now, as I've heavily refactored the network connection code so the source of this bug is probably long gone now, but I'm holding off until my fork has progressed to a state that I'll be happy with pushing to the main repository.

aliciasprig commented 10 years ago

I'm closing this bug as the relevant code paths have been heavily changed in 0.9.1 and there should be no unitialized data in the relevant code.

Re-open if this problem occurs again in a 0.9.1+ release.