search

DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
68 stars 41 forks source link

Updated to not disconnect the instruments when 'close' is called. Now… #598

Closed nielshaandbaek closed 4 years ago

nielshaandbaek commented 4 years ago

… the 'close' method will still work even if the server loses connection to the instrument. Also updated to not stop the running AWGs when 'close' is called (issue 155). Finally, a test was added for the new close behavior. The error stack is now cleared after the DIO calibration completes (in case it completes successfully).

Please use the following template for a pull request.

Fixes QuSurf issue #155, #163 and #152.

Changes proposed in this pull request: Updated the 'close' method to not disconnect the instrument from the server. This has the added benefit of solving the problem with the 'close' method not working if the server loses connection to the instrument. Also updated the DIO calibration procedures to clear the error stack after calibration completes successfully so that the user is not swamped by the DIO timing errors detected during calibration. Added a small test of the new close behavior.

@AdriaanRol, @MiguelSMoreira

MiguelSMoreira commented 4 years ago

Everything seems ok to merge