Closed wvlothuizen closed 4 years ago
Merging #600 into develop will increase coverage by
<.01%
. The diff coverage is60.97%
.
@@ Coverage Diff @@
## develop #600 +/- ##
===========================================
+ Coverage 42.95% 42.96% +<.01%
===========================================
Files 315 315
Lines 66681 66658 -23
===========================================
- Hits 28646 28638 -8
+ Misses 38035 38020 -15
Impacted Files | Coverage Δ | |
---|---|---|
...physical_instruments/ZurichInstruments/ZI_tools.py | 0% <ø> (ø) |
:arrow_up: |
...cal_instruments/ZurichInstruments/ZI_HDAWG_core.py | 46.66% <18.18%> (-0.84%) |
:arrow_down: |
...hysical_instruments/ZurichInstruments/ZI_HDAWG8.py | 32.65% <35.13%> (-0.01%) |
:arrow_down: |
...truments/ZurichInstruments/UHFQuantumController.py | 54.59% <68.67%> (+1.18%) |
:arrow_up: |
...nstruments/ZurichInstruments/ZI_base_instrument.py | 76.54% <84.84%> (-0.59%) |
:arrow_down: |
...vers/meta_instrument/qubit_objects/qubit_object.py | 22.9% <0%> (+0.1%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 55d9b8e...3e584b3. Read the comment docs.
Changes proposed in this pull request:
The changes in UHFQuantumController.py are difficult to track, because there are a lot of moves. The best I could find was to paste both versions into https://www.diff-text.com/diff-text-combined-navigation.aspx, and tick option 'don't show identical paragraphs'. Note that branch 'develop' contained function snapshot_base twice, so one is removed.
Can you have a look @MiguelSMoreira