DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
68 stars 41 forks source link

Fix default value ro_freq is null causing resonator scan to fail #608

Closed Odrenal closed 4 years ago

Odrenal commented 4 years ago

Steps to reproduce

1) use an new qubit object 2) run find_resonator_frequency() 3) watch it crash

Expected behaviour

function does resonator scan

Actual behaviour

function crashes with TypeError: unsupported operand type(s) for -: 'Nonetype' and 'float'.

AdriaanRol commented 4 years ago

👋 Who are you @Odrenal ?

MiguelSMoreira commented 4 years ago

This implementation of the resonator scan function already follows the expected behavior for the qubit object