Closed wvlothuizen closed 3 years ago
:exclamation: No coverage uploaded for pull request base (
develop@d36065d
). Click here to learn what that means. The diff coverage is35.77%
.
@@ Coverage Diff @@
## develop #620 +/- ##
==========================================
Coverage ? 45.15%
==========================================
Files ? 284
Lines ? 59804
Branches ? 0
==========================================
Hits ? 27002
Misses ? 32802
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
...qed/tests/dev_qubit_objs/test_mock_CCL_transmon.py | 99.05% <ø> (ø) |
|
pycqed/tests/dev_qubit_objs/test_qubit_objects.py | 93.2% <ø> (ø) |
|
...ent_drivers/meta_instrument/LutMans/flux_lutman.py | 72.96% <ø> (ø) |
|
...hysical_instruments/ZurichInstruments/ZI_HDAWG8.py | 33.1% <ø> (ø) |
|
...a_instrument/qubit_objects/CBox_driven_transmon.py | 20.18% <ø> (ø) |
|
pycqed/analysis_v2/tomography_V2.py | 54.32% <0%> (ø) |
|
pycqed/analysis_v2/tomography_dataprep.py | 75% <0%> (ø) |
|
pycqed/utilities/learnerND_minimizer.py | 10.89% <0%> (ø) |
|
...ycqed/measurement/qcodes_QtPlot_monkey_patching.py | 94.59% <100%> (ø) |
|
pycqed/tests/dev_qubit_objs/test_device_objects.py | 99.4% <100%> (ø) |
|
... and 8 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d36065d...7e7560d. Read the comment docs.
Got an OK from ETH/Christoph Hellings
After bringing develop up to date with our latest developments, I would like to merge this pull request into develop and delete this branch. Can I proceed @wvlothuizen ?
yes, let's proceed
The purpose of this PR is to get rid of unused stuff, in a reversible way. Unused code makes it more difficult to maintain the code base, and reduces code coverage since for many old pieces of code no tests exist.