DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
68 stars 41 forks source link

[WIP] revamped DIO calibration routine architecture #621

Closed wvlothuizen closed 3 years ago

wvlothuizen commented 4 years ago

Changes proposed in this pull request:

codecov-commenter commented 4 years ago

Codecov Report

Merging #621 into develop will increase coverage by 0.04%. The diff coverage is 56.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #621      +/-   ##
===========================================
+ Coverage    36.41%   36.45%   +0.04%     
===========================================
  Files          351      351              
  Lines        75642    75614      -28     
===========================================
+ Hits         27544    27566      +22     
+ Misses       48098    48048      -50     
Impacted Files Coverage Δ
...cal_instruments/ZurichInstruments/ZI_HDAWG_core.py 44.91% <0.00%> (-1.76%) :arrow_down:
...randomized_benchmarking/randomized_benchmarking.py 84.74% <ø> (ø)
...ent_drivers/physical_instruments/QuTech/test_CC.py 100.00% <ø> (ø)
pycqed/tests/openql/test_clifford_rb_oql.py 76.11% <0.00%> (-3.57%) :arrow_down:
...trument_drivers/physical_instruments/QuTech_QCC.py 33.42% <26.92%> (-3.29%) :arrow_down:
...trument_drivers/physical_instruments/QuTech_CCL.py 36.12% <29.41%> (-3.29%) :arrow_down:
...hysical_instruments/ZurichInstruments/ZI_HDAWG8.py 40.70% <37.14%> (+9.64%) :arrow_up:
...ment_drivers/physical_instruments/QuTech/CCCore.py 71.57% <55.55%> (-5.44%) :arrow_down:
.../measurement/openql_experiments/clifford_rb_oql.py 54.79% <66.66%> (ø)
...truments/ZurichInstruments/UHFQuantumController.py 59.46% <67.96%> (+5.39%) :arrow_up:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b03f153...362d265. Read the comment docs.

wvlothuizen commented 3 years ago

the changes to UHFQuantumController.py look daunting because several functions were moved. I used https://www.diff-text.com/diff-text-combined-navigation.aspx and https://compare-text-files.com/downloads.html to verify that everything is OK.