DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
68 stars 41 forks source link

Tests failing #629

Closed elrama- closed 3 years ago

elrama- commented 4 years ago

Tests are failing.

elrama- commented 4 years ago

Last working commit https://github.com/DiCarloLab-Delft/PycQED_py3/commit/02aa60ca7c41cbf80329a7a8ec2060a48fe10a31

caenrigen commented 4 years ago

@MiguelSMoreira need some help

I fixed a bunch of tests, need some help on a particular question that is making many tests in qubits and device objects fail: In 1932bbc79be7bf5b7fd9857f59d658a33067278e we added a self.UHFQC.sync() but the MockDAQServer in ZI_base_instrument.py does not have a .sync() method. UHFQC.sync() under the hood calls the sync() of a DAQ object. I don't feel qualified for this. In order to make the test pass do we need just a sync() method in the MockDAQServer that does nothing?

I would appreciate if you could fix implement a solution for this

nielshaandbaek commented 4 years ago

Here's the update: https://github.com/DiCarloLab-Delft/PycQED_py3/pull/634

caenrigen commented 4 years ago

@MiguelSMoreira next very important one, CC related, makes test_CC and test_device_objects fail. It seems to be to some change in communication protocol and maybe the problem is only updating the tests. Hope you can tell who can have a look at this

pycqed/instrument_drivers/physical_instruments/QuTech/CC.py:309: in set_func
    return fun(par1, val)
pycqed/instrument_drivers/physical_instruments/QuTech/CC.py:176: in _set_dio_delay
    self.stop()
pycqed/instrument_drivers/physical_instruments/QuTech/CCCore.py:144: in stop
    self.get_operation_complete()
pycqed/instrument_drivers/library/SCPIBase.py:66: in get_operation_complete
    return self._ask('*OPC?')
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <CC: cc>, cmd_str = '*OPC?'

    def _ask(self, cmd_str: str) -> str:
        self._transport.write(cmd_str)
>       return self._transport.readline().rstrip()  # remove trailing white space, CR, LF
E       AttributeError: ("'NoneType' object has no attribute 'rstrip'", 'setting cc_dio0_out_delay to 0')

pycqed/instrument_drivers/library/SCPIBase.py:176: AttributeError
caenrigen commented 4 years ago

@MiguelSMoreira next very important one, CC related, makes test_CC and test_device_objects fail. It seems to be to some change in communication protocol and maybe the problem is only updating the tests. Hope you can tell who can have a look at this

pycqed/instrument_drivers/physical_instruments/QuTech/CC.py:309: in set_func
    return fun(par1, val)
pycqed/instrument_drivers/physical_instruments/QuTech/CC.py:176: in _set_dio_delay
    self.stop()
pycqed/instrument_drivers/physical_instruments/QuTech/CCCore.py:144: in stop
    self.get_operation_complete()
pycqed/instrument_drivers/library/SCPIBase.py:66: in get_operation_complete
    return self._ask('*OPC?')
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <CC: cc>, cmd_str = '*OPC?'

    def _ask(self, cmd_str: str) -> str:
        self._transport.write(cmd_str)
>       return self._transport.readline().rstrip()  # remove trailing white space, CR, LF
E       AttributeError: ("'NoneType' object has no attribute 'rstrip'", 'setting cc_dio0_out_delay to 0')

pycqed/instrument_drivers/library/SCPIBase.py:176: AttributeError

@wvlothuizen could you help with this failing test? Miguel and me do not know what is this due to, we are trying to gradually fix pycqed tests

wvlothuizen commented 4 years ago

my bad, will try to fix this week

wvlothuizen commented 4 years ago

these two are solved in branch 'develop' now:

image

caenrigen commented 4 years ago

@wvlothuizen as discussed a bit ago there is this error in the tests related to the QWG/ip/communication protocol here a handy line to run the specific test:

pytest pycqed/tests/instrument_drivers/meta_instrument/LutMans/test_mw_lutman.py -v -k test_uploading_standard_pulses_QWG_lutman
caenrigen commented 4 years ago

@wvlothuizen as discussed a bit ago there is this error in the tests related to the QWG/ip/communication protocol here a handy line to run the specific test:

pytest pycqed/tests/instrument_drivers/meta_instrument/LutMans/test_mw_lutman.py -v -k test_uploading_standard_pulses_QWG_lutman

I believe after fixing this error we should have the test on develop back on track 😊

wvlothuizen commented 4 years ago

the test succeed again, let's also merge to master image

wvlothuizen commented 3 years ago

test were fixed, so closing, although they now fail again