Closed elrama- closed 3 years ago
@MiguelSMoreira need some help
I fixed a bunch of tests, need some help on a particular question that is making many tests in qubits and device objects fail:
In 1932bbc79be7bf5b7fd9857f59d658a33067278e we added a self.UHFQC.sync()
but the MockDAQServer
in ZI_base_instrument.py
does not have a .sync()
method. UHFQC.sync()
under the hood calls the sync()
of a DAQ object.
I don't feel qualified for this.
In order to make the test pass do we need just a sync()
method in the MockDAQServer
that does nothing?
I would appreciate if you could fix implement a solution for this
Here's the update: https://github.com/DiCarloLab-Delft/PycQED_py3/pull/634
@MiguelSMoreira next very important one, CC related, makes test_CC
and test_device_objects
fail. It seems to be to some change in communication protocol and maybe the problem is only updating the tests. Hope you can tell who can have a look at this
pycqed/instrument_drivers/physical_instruments/QuTech/CC.py:309: in set_func
return fun(par1, val)
pycqed/instrument_drivers/physical_instruments/QuTech/CC.py:176: in _set_dio_delay
self.stop()
pycqed/instrument_drivers/physical_instruments/QuTech/CCCore.py:144: in stop
self.get_operation_complete()
pycqed/instrument_drivers/library/SCPIBase.py:66: in get_operation_complete
return self._ask('*OPC?')
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <CC: cc>, cmd_str = '*OPC?'
def _ask(self, cmd_str: str) -> str:
self._transport.write(cmd_str)
> return self._transport.readline().rstrip() # remove trailing white space, CR, LF
E AttributeError: ("'NoneType' object has no attribute 'rstrip'", 'setting cc_dio0_out_delay to 0')
pycqed/instrument_drivers/library/SCPIBase.py:176: AttributeError
@MiguelSMoreira next very important one, CC related, makes
test_CC
andtest_device_objects
fail. It seems to be to some change in communication protocol and maybe the problem is only updating the tests. Hope you can tell who can have a look at thispycqed/instrument_drivers/physical_instruments/QuTech/CC.py:309: in set_func return fun(par1, val) pycqed/instrument_drivers/physical_instruments/QuTech/CC.py:176: in _set_dio_delay self.stop() pycqed/instrument_drivers/physical_instruments/QuTech/CCCore.py:144: in stop self.get_operation_complete() pycqed/instrument_drivers/library/SCPIBase.py:66: in get_operation_complete return self._ask('*OPC?') _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <CC: cc>, cmd_str = '*OPC?' def _ask(self, cmd_str: str) -> str: self._transport.write(cmd_str) > return self._transport.readline().rstrip() # remove trailing white space, CR, LF E AttributeError: ("'NoneType' object has no attribute 'rstrip'", 'setting cc_dio0_out_delay to 0') pycqed/instrument_drivers/library/SCPIBase.py:176: AttributeError
@wvlothuizen could you help with this failing test? Miguel and me do not know what is this due to, we are trying to gradually fix pycqed tests
my bad, will try to fix this week
these two are solved in branch 'develop' now:
@wvlothuizen as discussed a bit ago there is this error in the tests related to the QWG
/ip
/communication protocol
here a handy line to run the specific test:
pytest pycqed/tests/instrument_drivers/meta_instrument/LutMans/test_mw_lutman.py -v -k test_uploading_standard_pulses_QWG_lutman
@wvlothuizen as discussed a bit ago there is this error in the tests related to the
QWG
/ip
/communication protocol here a handy line to run the specific test:pytest pycqed/tests/instrument_drivers/meta_instrument/LutMans/test_mw_lutman.py -v -k test_uploading_standard_pulses_QWG_lutman
I believe after fixing this error we should have the test on develop
back on track 😊
the test succeed again, let's also merge to master
test were fixed, so closing, although they now fail again
Tests are failing.