DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 41 forks source link

Updated to check LabOne revision to select which nodes to write #636

Closed nielshaandbaek closed 3 years ago

nielshaandbaek commented 3 years ago

This MR updates the HDAWG PycQED driver to check the LabOne revision in order to determine which node to write to enable the QuSurf DIO mode. The update makes the PycQED driver compatible with LabOne 20.08.

Fixes #183.

Changes proposed in this pull request:

@MiguelSMoreira

In order for the pull request to be merged, the following conditions must be met:

Whenever possible the pull request should

Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.

codecov-commenter commented 3 years ago

Codecov Report

Merging #636 into develop will increase coverage by 0.00%. The diff coverage is 91.17%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #636   +/-   ##
========================================
  Coverage    36.41%   36.42%           
========================================
  Files          351      351           
  Lines        75643    75656   +13     
========================================
+ Hits         27545    27556   +11     
- Misses       48098    48100    +2     
Impacted Files Coverage Δ
...hysical_instruments/ZurichInstruments/ZI_HDAWG8.py 31.08% <40.00%> (+0.02%) :arrow_up:
...nstruments/ZurichInstruments/ZI_base_instrument.py 77.04% <100.00%> (+0.30%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93f6204...5d77049. Read the comment docs.