DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 41 forks source link

Added PQSC driver from ETH #641

Closed nielshaandbaek closed 2 years ago

nielshaandbaek commented 3 years ago

This PR adds the PQSC driver from ETH and improves it with proper error handling. It also adds the standard start and stop methods, which would be the preferred way of starting the PQSC. Secondly, the PR updates the ZI_base_instrument class to support instruments such as the PQSC that does not have an AWG.

Fixes #180.

Changes proposed in this pull request:

@chellings the name of someone you want to review this pull request.

In order for the pull request to be merged, the following conditions must be met:

Whenever possible the pull request should

Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.

chellings commented 3 years ago

Hey @nielshaandbaek I have looked at the new commits that you have force-pushed, but it seems that they are the same commits as before, i.e., the bug with _errors_to_ignore is still there.

nielshaandbaek commented 3 years ago

I finally updated the HDAWG too.