DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 41 forks source link

FIX CI errors (related to new OpenQL, or introduced otherwise) #643

Closed wvlothuizen closed 3 years ago

wvlothuizen commented 3 years ago

This PR fixes the failing CI tests by:

codecov-commenter commented 3 years ago

Codecov Report

Merging #643 (2febb27) into develop (13d72d1) will decrease coverage by 2.58%. The diff coverage is 37.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #643      +/-   ##
===========================================
- Coverage    35.31%   32.72%   -2.59%     
===========================================
  Files          355      316      -39     
  Lines        78075    69196    -8879     
===========================================
- Hits         27570    22646    -4924     
+ Misses       50505    46550    -3955     
Impacted Files Coverage Δ
pycqed/analysis/measurement_analysis.py 39.15% <0.00%> (-12.40%) :arrow_down:
pycqed/analysis_v2/multiplexed_readout_analysis.py 5.92% <0.00%> (+0.01%) :arrow_up:
pycqed/analysis_v2/spectroscopy_analysis.py 34.97% <0.00%> (-0.17%) :arrow_down:
pycqed/analysis_v2/timedomain_analysis.py 31.22% <0.00%> (ø)
pycqed/analysis_v2/tomography_V2.py 54.32% <0.00%> (-0.92%) :arrow_down:
pycqed/analysis_v2/tomography_dataprep.py 75.00% <0.00%> (-1.00%) :arrow_down:
pycqed/instrument_drivers/library/DIO.py 32.35% <ø> (ø)
...ent_drivers/meta_instrument/LutMans/flux_lutman.py 24.96% <ø> (ø)
...rivers/meta_instrument/device_dependency_graphs.py 0.00% <ø> (ø)
...ers/meta_instrument/device_dependency_graphs_v2.py 0.00% <0.00%> (ø)
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e741f1d...2febb27. Read the comment docs.

wvlothuizen commented 3 years ago

@MiguelSMoreira can you have a look?

MiguelSMoreira commented 3 years ago

@MiguelSMoreira can you have a look?

@wvlothuizen just did. Please feel free to merge the PR after pulling from develop! And thank you for taking care of this!