DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 41 forks source link

further deprecation of unused functionality #646

Closed wvlothuizen closed 2 years ago

wvlothuizen commented 3 years ago

Please use the following template for a pull request.

Fixes #issuenumber.

Changes proposed in this pull request:

@mention the name of someone you want to review this pull request.

In order for the pull request to be merged, the following conditions must be met:

Whenever possible the pull request should

Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.

codecov-commenter commented 3 years ago

Codecov Report

Merging #646 (b4cf532) into develop (5338c51) will increase coverage by 2.75%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #646      +/-   ##
===========================================
+ Coverage    32.72%   35.48%   +2.75%     
===========================================
  Files          316      288      -28     
  Lines        69211    60875    -8336     
===========================================
- Hits         22651    21599    -1052     
+ Misses       46560    39276    -7284     
Impacted Files Coverage Δ
...ycqed/instrument_drivers/meta_instrument/Magnet.py 0.00% <ø> (ø)
...vers/meta_instrument/qubit_objects/CCL_Transmon.py 10.87% <ø> (-0.07%) :arrow_down:
pycqed/measurement/calibration_toolbox.py 12.87% <ø> (+0.46%) :arrow_up:
pycqed/measurement/composite_detector_functions.py 9.31% <ø> (-0.40%) :arrow_down:
pycqed/measurement/cz_cost_functions.py 10.00% <ø> (-13.73%) :arrow_down:
pycqed/measurement/detector_functions.py 32.50% <ø> (+5.89%) :arrow_up:
pycqed/measurement/optimization.py 86.99% <ø> (-0.51%) :arrow_down:
pycqed/measurement/sweep_functions.py 23.04% <ø> (+0.06%) :arrow_up:
pycqed/tests/dev_qubit_objs/test_qubit_objects.py 18.83% <ø> (-1.05%) :arrow_down:
pycqed/tests/openql/test_generate_CCL_cfg.py 100.00% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5338c51...b4cf532. Read the comment docs.

MiguelSMoreira commented 2 years ago

@wvlothuizen shall we incorporate the deprecations proposed in this PR in the develop branch? if so, could we please pull develop again onto feature/cleanup and solve any remaining conflicts before proceeding? I will be happy to quickly review the changes after that is done!