DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 41 forks source link

[WIP] remove old fix on plotly version #648

Closed peendebak closed 2 years ago

peendebak commented 3 years ago

Changes proposed in this pull request:

The plotly version is old, and the reason for pinning it (pyGSTi) is not valid any more (#542) in more recent versions.

MiguelSMoreira commented 2 years ago

Should be fine, I will merge it! Thanks @peendebak

peendebak commented 2 years ago

@MiguelSMoreira This PR was labelled WIP because I was checking whether the new pygsti is compatible with pycqed code. Did you check the system are compatible now?

MiguelSMoreira commented 2 years ago

@peendebak Well, reading your first comment "The plotly version is old, and the reason for pinning it (pyGSTi) is not valid any more (#542) in more recent versions." that is not really what one takes away. I was under the impression that you had already checked this. If that is not the case, then we should check now and, if not compatible, revert the merge!