DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 41 forks source link

Added function to return minimum readout hold-off including unit test. #651

Closed nielshaandbaek closed 2 years ago

nielshaandbaek commented 3 years ago

Fixes #191.

Changes proposed in this pull request:

@chellings

In order for the pull request to be merged, the following conditions must be met:

Whenever possible the pull request should

Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.

codecov-commenter commented 3 years ago

Codecov Report

Merging #651 (10908d8) into develop (2d0c14e) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #651      +/-   ##
===========================================
+ Coverage    32.72%   32.75%   +0.02%     
===========================================
  Files          316      316              
  Lines        69212    69235      +23     
===========================================
+ Hits         22652    22676      +24     
+ Misses       46560    46559       -1     
Impacted Files Coverage Δ
...truments/ZurichInstruments/UHFQuantumController.py 37.69% <100.00%> (+0.63%) :arrow_up:
...trument_drivers/physical_instruments/test_UHFQC.py 86.84% <100.00%> (+2.30%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d0c14e...10908d8. Read the comment docs.