search

DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 41 forks source link

[RFC] autopep8 #652

Closed eendebakpt closed 1 year ago

eendebakpt commented 3 years ago

Changes proposed in this pull request:

Using automatic formatters keeps code clean and allows for a uniform coding style. This PR applied autopep8 (basic settings, but with max line length 120). This is in line with the issue template and contributing guidelines which prefer autopep8 (https://github.com/DiCarloLab-Delft/PycQED_py3/blob/develop/.github/CONTRIBUTING.md)

Related is #649 which adds configuration files to automatically format according to autopep8 on commiting.

Once we agree, we will autopep all files in the repository.

@wvlothuizen @MiguelSMoreira

codecov-commenter commented 3 years ago

Codecov Report

Merging #652 (cc3bcaf) into develop (2d0c14e) will decrease coverage by 0.00%. The diff coverage is 23.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #652      +/-   ##
===========================================
- Coverage    32.72%   32.72%   -0.01%     
===========================================
  Files          316      316              
  Lines        69212    69214       +2     
===========================================
  Hits         22652    22652              
- Misses       46560    46562       +2
Impacted Files Coverage Δ
...ent_drivers/physical_instruments/MinicircuitsRC.py 0.00% <0.00%> (ø)
...physical_instruments/QuTech_SPI_S4g_FluxCurrent.py 0.00% <ø> (ø)
...ument_drivers/physical_instruments/RIGOL_DS4043.py 0.00% <0.00%> (ø)
...instrument_drivers/physical_instruments/RTO1024.py 0.00% <0.00%> (ø)
...nstrument_drivers/physical_instruments/SCPIBase.py 0.00% <0.00%> (ø)
...rs/physical_instruments/Stroboscope/Stroboscope.py 0.00% <0.00%> (ø)
...strument_drivers/physical_instruments/Transport.py 0.00% <0.00%> (ø)
...vers/physical_instruments/Weinschel_8320_novisa.py 0.00% <0.00%> (ø)
...d/instrument_drivers/physical_instruments/ZNB20.py 0.00% <ø> (ø)
...cal_instruments/ZurichInstruments/ZI_HDAWG_core.py 44.06% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d0c14e...cc3bcaf. Read the comment docs.

wvlothuizen commented 3 years ago

Why limit this to physical_instruments?

eendebakpt commented 3 years ago

@wvlothuizen Full autopep takes quite some time. This is a start to keep feedback on the format. If we agree, then I will do a full autopep8.