DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 41 forks source link

updates for QWG #654

Closed wvlothuizen closed 2 years ago

wvlothuizen commented 3 years ago

Please use the following template for a pull request.

Fixes #issuenumber.

Changes proposed in this pull request:

@mention the name of someone you want to review this pull request.

In order for the pull request to be merged, the following conditions must be met:

Whenever possible the pull request should

Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.

codecov-commenter commented 3 years ago

Codecov Report

Merging #654 (fdb6af8) into develop (2d0c14e) will decrease coverage by 1.90%. The diff coverage is 24.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #654      +/-   ##
===========================================
- Coverage    32.72%   30.81%   -1.91%     
===========================================
  Files          316      325       +9     
  Lines        69212    72312    +3100     
===========================================
- Hits         22652    22286     -366     
- Misses       46560    50026    +3466     
Impacted Files Coverage Δ
pycqed/analysis_v2/fluxing_analysis.py 6.83% <0.00%> (-0.09%) :arrow_down:
pycqed/analysis_v2/readout_analysis.py 48.35% <0.00%> (-0.16%) :arrow_down:
pycqed/analysis_v2/tools/data_extraction_utlis.py 0.00% <ø> (ø)
pycqed/instrument_drivers/library/Transport.py 56.33% <ø> (-1.41%) :arrow_down:
...drivers/meta_instrument/LutMans/flux_lutman_vcz.py 0.00% <0.00%> (ø)
...ument_drivers/meta_instrument/device_object_CCL.py 8.64% <ø> (-1.98%) :arrow_down:
...vers/meta_instrument/qubit_objects/qubit_object.py 13.17% <0.00%> (ø)
...strument_drivers/physical_instruments/QuTech/CC.py 59.61% <ø> (ø)
...ment_drivers/physical_instruments/QuTech/CCCore.py 70.29% <ø> (ø)
..._drivers/physical_instruments/QuTech_AWG_Module.py 45.18% <ø> (-0.39%) :arrow_down:
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ee35c7...fdb6af8. Read the comment docs.