Closed nielshaandbaek closed 2 years ago
Merging #656 (85890ee) into develop (afdcf2d) will increase coverage by
0.10%
. The diff coverage is65.44%
.
@@ Coverage Diff @@
## develop #656 +/- ##
===========================================
+ Coverage 32.71% 32.82% +0.10%
===========================================
Files 316 319 +3
Lines 69284 69374 +90
===========================================
+ Hits 22667 22769 +102
+ Misses 46617 46605 -12
Impacted Files | Coverage Δ | |
---|---|---|
...sical_instruments/ZurichInstruments/UHFQA_qudev.py | 0.00% <0.00%> (ø) |
|
...cal_instruments/ZurichInstruments/ZI_HDAWG_core.py | 45.45% <ø> (+1.38%) |
:arrow_up: |
...trument_drivers/physical_instruments/test_UHFQC.py | 69.38% <ø> (-15.15%) |
:arrow_down: |
...nstruments/ZurichInstruments/ZI_base_instrument.py | 68.95% <41.93%> (-0.99%) |
:arrow_down: |
...truments/ZurichInstruments/UHFQuantumController.py | 28.40% <44.44%> (-8.66%) |
:arrow_down: |
...ysical_instruments/ZurichInstruments/UHFQA_core.py | 63.81% <63.81%> (ø) |
|
...nt_drivers/physical_instruments/test_UHFQA_core.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update afdcf2d...85890ee. Read the comment docs.
The purpose of this PR is to refactor the
UHFQuantumController
module in a similar fashion as was done for the HDAWG. As a result, a new module has been created namedUHFQA_core
containing a class of the same name with the core functionality of the driver. TheUHFQC
class has been simplified accordingly and is now derived fromUHFQA_core
. Additionally, aUHFQA_qudev
module has been created with Qudev specific functionality.Fixes #194.
Changes proposed in this pull request:
UHFQA_core
module with core functionality.UHFQuantumController
removing core functionality.UHFQA_qudev
.@MiguelSMoreira @chellings
In order for the pull request to be merged, the following conditions must be met:
Whenever possible the pull request should
Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.