Fixed bug in _get_waveform_table preventing start() from working in UHFQA_core. After refactoring there was some functionality preventing UHFQA_core and derived classes from executing experiments.
Changes proposed in this pull request:
Changed default implementation of _get_waveform_table to return an empty dict()
Added unittest of start() for `UHFQA_core
@chellings
In order for the pull request to be merged, the following conditions must be met:
test suite (Github actions) passes
all reasonable issues raised by codacy must be resolved
a positive review is required
Whenever possible the pull request should
follow the PEP8 style guide
have tests for the code
be well documented and contain comments
Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.
Fixed bug in
_get_waveform_tablepreventing start() from working in UHFQA_core. After refactoring there was some functionality preventingUHFQA_coreand derived classes from executing experiments.Changes proposed in this pull request:
_get_waveform_tableto return an emptydict()start()for `UHFQA_core@chellings
In order for the pull request to be merged, the following conditions must be met:
Whenever possible the pull request should
Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.