search

DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 41 forks source link

further cleanup #669

Closed wvlothuizen closed 2 years ago

wvlothuizen commented 2 years ago

Prior deprecations (PR #620 and #646) moved unused files to a hierarchy under "/deprecated", and commented out parts of files that referred to these unused files. This scheme is used to ease reverting any deprecation if necessary.

With the release of PycQED version 0.3 as a solid base to fall back to, this PR now removes these commented out parts as a further stage of cleaning up

codecov-commenter commented 2 years ago

Codecov Report

Merging #669 (5f6ae69) into develop (3470e7c) will increase coverage by 0.08%. The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #669      +/-   ##
===========================================
+ Coverage    33.31%   33.39%   +0.08%     
===========================================
  Files          297      297              
  Lines        63983    63622     -361     
===========================================
- Hits         21316    21248      -68     
+ Misses       42667    42374     -293
Impacted Files Coverage Δ
pycqed/analysis_v2/tomography_V2.py 54.10% <ø> (-0.23%) :arrow_down:
pycqed/analysis_v2/tomography_dataprep.py 73.94% <ø> (-1.06%) :arrow_down:
...ument_drivers/meta_instrument/LutMans/mw_lutman.py 34.94% <ø> (-1.93%) :arrow_down:
pycqed/measurement/calibration_toolbox.py 11.53% <ø> (-1.35%) :arrow_down:
pycqed/measurement/cz_cost_functions.py 9.80% <ø> (ø)
pycqed/measurement/optimization.py 86.99% <ø> (ø)
pycqed/measurement/sweep_functions.py 21.90% <ø> (-0.04%) :arrow_down:
...qed/tests/dev_qubit_objs/test_mock_CCL_transmon.py 44.33% <ø> (ø)
pycqed/tests/dev_qubit_objs/test_qubit_objects.py 18.83% <ø> (ø)
...rivers/meta_instrument/LutMans/test_flux_lutman.py 65.25% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3470e7c...5f6ae69. Read the comment docs.