search

DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 41 forks source link

Group related methods #671

Closed wvlothuizen closed 2 years ago

wvlothuizen commented 2 years ago

This PR reorders methods in some core parts of PycQED to allow better insight in the inheritance structure (and quirks thereof). Because it is sort of impossible to track history when shuffling around code within files, this PR does not change any functionality. Some comments were added however in places where questionable things happen.

Note that other changes to the files involved should ideally not be carried over the merge of this PR (so merge any other changes in progress before this PR, and after this PR, pull develop before editing).

Subsequent steps are foreseen to improve LutMan and codeword handling.

codecov-commenter commented 2 years ago

Codecov Report

Merging #671 (fa78588) into develop (5f6ae69) will increase coverage by 0.01%. The diff coverage is 29.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #671      +/-   ##
===========================================
+ Coverage    33.39%   33.41%   +0.01%     
===========================================
  Files          297      297              
  Lines        63622    63582      -40     
===========================================
- Hits         21248    21246       -2     
+ Misses       42374    42336      -38
Impacted Files Coverage Δ
pycqed/analysis/fit_toolbox/functions.py 16.26% <ø> (ø)
...ument_drivers/meta_instrument/device_object_CCL.py 8.64% <ø> (+0.08%) :arrow_up:
...vers/meta_instrument/qubit_objects/CCL_Transmon.py 10.87% <ø> (+0.08%) :arrow_up:
pycqed/measurement/sweep_functions.py 21.90% <ø> (ø)
...ument_drivers/meta_instrument/LutMans/mw_lutman.py 34.73% <26.36%> (-0.22%) :arrow_down:
...vers/meta_instrument/qubit_objects/qubit_object.py 11.19% <26.82%> (+0.04%) :arrow_up:
...ument_drivers/meta_instrument/LutMans/ro_lutman.py 43.06% <33.33%> (-0.29%) :arrow_down:
...ent_drivers/meta_instrument/LutMans/base_lutman.py 38.59% <66.66%> (ø)
..._drivers/meta_instrument/LutMans/test_mw_lutman.py 68.24% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f6ae69...fa78588. Read the comment docs.