Closed wvlothuizen closed 2 years ago
Merging #675 (759e68a) into develop (2d0c14e) will increase coverage by
3.46%
. The diff coverage is30.94%
.
@@ Coverage Diff @@
## develop #675 +/- ##
===========================================
+ Coverage 32.72% 36.19% +3.46%
===========================================
Files 316 302 -14
Lines 69212 65699 -3513
===========================================
+ Hits 22652 23781 +1129
+ Misses 46560 41918 -4642
Impacted Files | Coverage Δ | |
---|---|---|
pycqed/analysis/fit_toolbox/functions.py | 21.95% <ø> (ø) |
|
pycqed/analysis_v2/VQE_EVC.py | 0.00% <ø> (ø) |
|
pycqed/analysis_v2/VQE_EVC_2.py | 0.00% <ø> (ø) |
|
pycqed/analysis_v2/fluxing_analysis.py | 6.83% <0.00%> (-0.09%) |
:arrow_down: |
pycqed/analysis_v2/spectroscopy_analysis.py | 34.97% <ø> (ø) |
|
pycqed/analysis_v2/tools/data_extraction_utlis.py | 0.00% <ø> (ø) |
|
pycqed/instrument_drivers/library/Transport.py | 60.56% <ø> (+2.81%) |
:arrow_up: |
...instrument_drivers/meta_instrument/Flux_Control.py | 0.00% <ø> (ø) |
|
...d/instrument_drivers/meta_instrument/HAL_Device.py | 4.68% <ø> (ø) |
|
...ent_drivers/meta_instrument/LutMans/flux_lutman.py | 24.96% <0.00%> (ø) |
|
... and 196 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 23acccc...759e68a. Read the comment docs.
@MiguelSMoreira I guess it would be advantageous to merge this before new developments will start to prevent new conflicts now things have moved around. I merged with the recent updates in branch 'develop' and fixed CI. It would be good to take a special look at the last few commits that fix conflicts and CI. Maybe other people should also review, I'll leave that for you to decide.
This PR is intended to split off the hardware handling from the files below, as an initial step to handle hardware in a separate 'layer':
The following still need a similar split-up:
Some class and file names have been changed to better reflect the current situation (e.g. "CCLight" is removed), but to maintain compatibility the old names and locations are still supported through 'compatibility imports'.
This PR takes a lot of care to not break anything for the end user, but in the slipstream of this PR:
A subsequent step in a follow-up PR would be to integrate the HW management for single vs. multi qubit experiments, and more clearly assign the responsibilities of all the components involved