search

DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 40 forks source link

Hide dependency of CC to shfqa driver using magic number mask #705

Closed martinr-zi closed 2 years ago

martinr-zi commented 2 years ago

Use a magic number for the dio mask used in calibration of the SHFQA instead of introducing a programmatic dependency to the SHFQA driver. This fixes the breaking build for the central controller for 3.6.

codecov[bot] commented 2 years ago

Codecov Report

Merging #705 (d0ad0de) into develop (21d8576) will decrease coverage by 0.31%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #705      +/-   ##
===========================================
- Coverage    35.97%   35.65%   -0.32%     
===========================================
  Files          301      301              
  Lines        66198    66196       -2     
===========================================
- Hits         23815    23603     -212     
- Misses       42383    42593     +210
Impacted Files Coverage Δ
...strument_drivers/physical_instruments/QuTech/CC.py 60.74% <0.00%> (+0.19%) :arrow_up:
...l_instruments/ZurichInstruments/shfqa_codewords.py 0.00% <0.00%> (-51.36%) :arrow_down:
...nts/ZurichInstruments/shfqa_uhfqc_compatibility.py 0.00% <0.00%> (-50.88%) :arrow_down:
...l_instruments/ZurichInstruments/internal/_shfqa.py 0.00% <0.00%> (-42.75%) :arrow_down:
pycqed/analysis/analysis_toolbox.py 43.02% <0.00%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21d8576...d0ad0de. Read the comment docs.