search

DiCarloLab-Delft / PycQED_py3

Python3 version of PycQED using QCoDeS as backend
MIT License
67 stars 40 forks source link

Martinr/adapt shfqa dio cal to 2208 #713

Closed martinr-zi closed 1 year ago

martinr-zi commented 1 year ago

Implement new way of doing DIO calibration with SHFQA 22.08.

Adapt imports to the new package structure of zhinst.

wvlothuizen commented 1 year ago

I'm basically fine with the code changes, but requiring LabOne 22.08 implies requiring Python >= 3.7, and the PR for that (https://github.com/DiCarloLab-Delft/PycQED_py3/pull/700) is still open.

What's the status on Python3.7, @MiniSean ?

MiniSean commented 1 year ago

The changes look good to me. PR #700 should not be far behind as I am almost done cleaning up the unit tests.