Open ysalatheZI opened 1 year ago
This pull request is ready for review.
@RuggeroDiCarlo and @leodicarlo, what is the status of these changes? Have they already been tested on the Inspire setup?
After talking with @RuggeroDiCarlo I understand that there are two (identical) instances of this code.
One existing in this PR, and one already existing on the Inspire setup (not yet pushed to the inspire_detached
branch).
After doing a branch comparison (for the relevant file UHFQC.py
) both are indeed identical and working as intended.
Naturally I rather not push changes this way since it is very sensitive to errors and merge conflicts. But we can make an exception for this PR.
Please use the following template for a pull request.
Loop over detectors in the inner-most poll loop in the UHF multi detector.
@leodicarlo , @mariosk-zi
In order for the pull request to be merged, the following conditions must be met:
Whenever possible the pull request should
Tests are not mandatory as this is generally hard to make for instruments that interact with hardware.