search

DiNitride / Discord-Music-Status

A Self-Bot program to display your music from Spotify, iTunes, Winamp, and other music players, as your "Playing" status on Discord
72 stars 19 forks source link

What licence is this under #30

Open miawgogo opened 6 years ago

miawgogo commented 6 years ago

Hi, i just forked this to make a version that use MPRIS on linux instead of snip and i just realised that there was no licence. so im just checking if it was ok for me to fork it and implement a linux version

DiNitride commented 6 years ago

On Mon, 20 Nov 2017 at 11:01, Ioan Loosley notifications@github.com wrote:

Hi, i just forked this to make a version that use MPRIS on linux instead of snip and i just realised that there was no licence. so im just checking if it was ok for me to fork it and implement a linux version

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DiNitride/Discord-Music-Status/issues/30, or mute the thread https://github.com/notifications/unsubscribe-auth/AQznL1RuakvDjFmGXLk3j8WztXkb1xaRks5s4VwMgaJpZM4QkFeG .

Haha yeah I should add one mb,

Anyway that's fine man, go ahead :) I was thinking of making a Linux and MacOS version anyway.

I'm thinking of rewriting it to include Linux and MacOS supports, if you want feel free to PR back in and we can work into some cool magic system that uses whatever version is necessary

miawgogo commented 6 years ago

Yeah, ok. I'll rework my changes when i have the time as it is currently spaghetti code trying to see if it would work. I also need to find a way to make it work even if there is no media player due to how dbus-python lets you accsess the IPC

DiNitride commented 6 years ago

On Mon, 20 Nov 2017 at 11:38, Ioan Loosley notifications@github.com wrote:

Yeah, ok. I'll rework my changes when i have the time as it is currently spaghetti code trying to see if it would work. I also need to find a way to make it work even if there is no media player due to how dbus-python lets you accsess the IPC

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/DiNitride/Discord-Music-Status/issues/30#issuecomment-345671133, or mute the thread https://github.com/notifications/unsubscribe-auth/AQznL6zuIaT-w2DrDuA5BsL5ZHO5illkks5s4WTGgaJpZM4QkFeG .

Sounds good, I think one method my mate did on Linux was just reading the window title, but that was for Spotify only

miawgogo commented 6 years ago

Yeah, it will work with any player that has MPRIS implemted(Tested using Spotify and Rhythm Box), Im just going to add the snip code back in. just one question, do you want to do it where at the beginning we probe the OS type and then load a module in from the current working directory that contains the pull_song() function and other support functions? pull_song() seems to be the only one that needs changes across platforms

DiNitride commented 6 years ago

On Mon, 20 Nov 2017 at 12:17, Ioan Loosley notifications@github.com wrote:

Yeah, this one will work with any player that has MPRIS implemted, Im just going to add the snip code back in. just one question, do you want to do it where at the beginning we probe the OS type and then load a module in from the current working directory that contains the pull_song() function and other support functions? pull_song() seems to be the only one that needs changes across platforms

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/DiNitride/Discord-Music-Status/issues/30#issuecomment-345679514, or mute the thread https://github.com/notifications/unsubscribe-auth/AQznL2Q84EXXeQXFB5Yz28dDJKXml97cks5s4W3lgaJpZM4QkFeG .

I was thinking of probing for OS at the start, or it can be overridden with cli args

miawgogo commented 6 years ago

Yeah, The code i just pushed has the option to do this

DiNitride commented 6 years ago

I merged into a new branch to retain stability in master. Also for our MacOS, see #27