Bookmarking does not work in Multicontrollers

DiODeProject / MuMoT

Multiscale Modelling Tool - mathematical modelling without the maths

https://mumot.readthedocs.io/

GNU General Public License v3.0

21 stars 4 forks source link

Bookmarking does not work in Multicontrollers #279

Closed joefresna closed 5 years ago

jarmarshall commented 5 years ago

The is a bit odd as it worked as of commit 9f77564b2e95ad5b6760eb69964987732d877045 ; it seems that _print_standalone_view_cmd() is heavily overloaded, having at least 3 forms with different arguments... this may have contributed also to issue #255

joefresna commented 5 years ago

Latest commit in #286 solved this issue

joefresna commented 5 years ago

and now (I believe for the first time ever), bookmarking also works for nested multicontrollers. Although, it would be beneficial to enforce silent=True to all child views (currently not done).

jarmarshall commented 5 years ago

Great, thanks - saves me some work 😃

Although I'm fairly sure nested multicontroller bookmarks have worked in the past, e.g. in mid-December, but as-yet unidentified code rot seemed to set in after that. I was testing this stuff fairly intensively!

jarmarshall commented 5 years ago

Good to close I think @joefresna