search

DiODeProject / MuMoT

Multiscale Modelling Tool - mathematical modelling without the maths
https://mumot.readthedocs.io/
GNU General Public License v3.0
21 stars 5 forks source link

Field plots in multiController crash when MuMoTstochasticSimulationView keywords are specified #285

Closed joefresna closed 5 years ago

joefresna commented 5 years ago

This bug appeared prior to pull requests #276

See attached notebook for an example issue285.zip

jarmarshall commented 5 years ago

Is this a more general suggestion that view-creating commands should not crash when they receive unexpected keyword arguments?

jarmarshall commented 5 years ago

The solution is currently is to move the keywords down to the lowest level in the multicontroller at which they are meaningful, in this case within the SSA controller creation...

jarmarshall commented 5 years ago

Hmmm... already stream() ignores irrelevant keywords... e.g. model4.stream('\\alpha','B',foo = True) works... And indeed moving those SSA-specific keywords directly into the creation of the stream view also works... The error is that somehow these arguments are being parsed... currently no idea why...

jarmarshall commented 5 years ago

A bit more info - moving the showNoise keyword up to the multicontroller level does not cause an error - it also does not result in noise being calculated in the stream view, which I think is expected since the stream controller needs to be created before the multicontroller, hence does not see the keyword on creation.

joefresna commented 5 years ago

I've the feeling that solving #290 could help in some of these recent issues....

joefresna commented 5 years ago

Indeed, solving #290 has also fixed this :-)

jarmarshall commented 5 years ago

Good to close I think @joefresna